RFR: 8304014: Convert test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java to junit [v5]

Eirik Bjorsnos duke at openjdk.org
Fri Mar 31 19:59:14 UTC 2023


On Fri, 31 Mar 2023 17:27:25 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Eirik Bjorsnos has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Document the structure of the 'good' ZIP
>>  - Use the "Validate that.." comment style
>>  - Document the ByteBuffer with a comment
>>  - Use ByteBuffer when manipulating multi-byte fields
>
> test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java line 56:
> 
>> 54:      * Byte array holding a valid template ZIP.
>> 55:      *
>> 56:      * This 'good' ZIP file has the following structure:
> 
> Change this -> the

Fixed.

> test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java line 203:
> 
>> 201:     /*
>> 202:      * Validate that a ZipException is thrown when a A CEN header has an unexpected signature
>> 203:      */
> 
> change  "a A" to "a"

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12563#discussion_r1154840888
PR Review Comment: https://git.openjdk.org/jdk/pull/12563#discussion_r1154841007


More information about the core-libs-dev mailing list