RFR: 8304014: Convert test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java to junit [v5]

Fri Mar 31 20:10:17 UTC 2023

On Fri, 31 Mar 2023 18:37:58 GMT, Martin Buchholz <martin at openjdk.org> wrote:

> I support rewriting tests like this into junit 5.

Glad to hear! I would be a bit sad to hear you were against this.

> I wrote many jdk tests (like this) before a standard high quality test framework like junit 5 was available.

And thank you for that!

> Zip file implementations are 90% corner cases, so expanding testing and improving testability of jdk classes would be valuable. For example, it would be nice to explicitly request use of ZIP64 extensions even when they are not needed, to avoid having to create multi-gigabyte test files.

Indeed. I would also just love to be able  to transform existing ZIP files into Zip64 format, regardless of their current format. And along the way transform any ZIP record or field in a type-safe manner. Stay tuned for suggestions in this area..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12563#issuecomment-1492552840