RFR: 8304888: Add dedicated VMProps for linker and fallback linker [v4]

Jorn Vernee jvernee at openjdk.org
Tue May 2 11:05:21 UTC 2023


On Tue, 2 May 2023 10:16:17 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 46 commits:
>> 
>>  - UNKNOWN -> UNSUPPORTED + fix TestLinker on FALLBACK
>>  - Merge branch 'master' into VMProps
>>  - Merge branch 'master' into VMProps
>>  - use only jdk.CABI property
>>  - use extra props to check for linker
>>  - Add fallbackLinker vmprop
>>  - Merge pull request #3 from JornVernee/IsForeignLinkerSupported
>>    
>>    rename has_port
>>  - rename has_port
>>  - Merge pull request #2 from JornVernee/WSL_BB
>>    
>>    account for missing functional in WSL in TestByteBuffer
>>  - account for missing mincore on WSL in TestByteBuffer
>>  - ... and 36 more: https://git.openjdk.org/jdk/compare/7d07d195...272478b6
>
> test/jdk/java/foreign/SafeFunctionAccessTest.java line 27:
> 
>> 25:  * @test
>> 26:  * @enablePreview
>> 27:  * @requires jdk.CABI != "UNSUPPORTED"
> 
> what about the name `jdk.native.abi` ?

Not so sure. The CABI is really the linker kind, not the underlying ABI ('CABI' is probably a misnomer at this point, since we no longer use it for anything else besides selecting the linker implementation). It can also be `FALLBACK` which is not an ABI.

If CABI is bad, I think `jdk.foreign.linker` would be better as a property name

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13429#discussion_r1182397282


More information about the core-libs-dev mailing list