RFR: 8303530: Add system property for custom JAXP configuration file [v9]

Joe Wang joehw at openjdk.org
Tue May 2 20:16:24 UTC 2023


On Sun, 30 Apr 2023 07:37:07 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Joe Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8303530
>>  - Update based on the review meeting on 4/5. Added (duplicated) definitions in jaxp.properties; Rewrote Property Precedence with samples; Other updates.
>>  - update javadoc as discussed in the review meeting; add a sample configuration file jaxp.properties; update impl and tests accordingly.
>>  - continue support stax.properties at the impl level, though dropped from the spec
>>  - change prefix from jdk to java
>>  - change prefix from jdk to java; rm zip file that accidentally checked in
>>  - update config file description; add a general scope and order section; move value definition for external properties to class description
>>  - clean up tests; fix copy&paste error.
>>  - 8303530: Add system property for custom JAXP configuration file
>
> src/java.xml/share/classes/module-info.java line 257:
> 
>> 255:  * the {@link javax.xml.XMLConstants#FEATURE_SECURE_PROCESSING FEATURE_SECURE_PROCESSING}
>> 256:  * (hereafter referred to FSP), and the default values. The order of precedence
>> 257:  * for the configuration sources is defined as follows, with earlier ones overriding the later:
> 
> "using the API properties" is bit confusing. I think you mean that properties can be set via the APIs. 
> 
> ".. and the default values". I think it would be clearer to say that properties have default values when not set by previous four ways.

Updated accordingly in additional commits.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12985#discussion_r1183005119


More information about the core-libs-dev mailing list