Integrated: 8303919: Instant.ofEpochMilli says it can throw an exception that it can't

Eamonn McManus emcmanus at openjdk.org
Tue May 2 23:29:20 UTC 2023


On Thu, 9 Mar 2023 19:49:29 GMT, Eamonn McManus <emcmanus at openjdk.org> wrote:

> Instant.ofEpochMilli says this:
> 
> 
> @throws DateTimeException if the instant exceeds the maximum or minimum instant
> 
> 
> But that can't happen. Even given `Long.MIN_VALUE` or `Long.MAX_VALUE` it does not throw. That's already implicitly tested in [`TestInstant`](https://github.com/openjdk/jdk/blob/a9dba565688a29bef8626488c47519008dcadbe8/test/jdk/java/time/test/java/time/TestInstant.java#L84), which calls it with both those values.

This pull request has now been integrated.

Changeset: 74667e3d
Author:    Eamonn McManus <emcmanus at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/74667e3d56a0e6780363359b69007770f5678d8e
Stats:     1 line in 1 file changed: 0 ins; 1 del; 0 mod

8303919: Instant.ofEpochMilli says it can throw an exception that it can't

Reviewed-by: rriggs

-------------

PR: https://git.openjdk.org/jdk/pull/12958


More information about the core-libs-dev mailing list