RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]

Mahendra Chhipa mchhipa at openjdk.org
Wed May 3 14:15:16 UTC 2023


On Tue, 2 May 2023 16:27:25 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> This is added in setup method to create the serialized data with current JDK version (JDK under test). In addition to serialized data generated with old JDK version.
>
> Sorry, I still disagree with this.  Your comment in the test is as follows:
> 
> `// Generates the Java Pseudo code for base64 encoded string that can be cut & pasted into the test`
> 
> Which is what the method does and to facilitate it, as an example print it out so that it can be copied and pasted
> 
> ` System.out.println(sb);`
> 
> Again, there is no reason to include this code in the setup method, it should be segmented out into its own method with instructions with how to create the encoded string

Hi Lance, Initially I misunderstood the comment. Now I move the pseudo code generation code to separate methods.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1183746563


More information about the core-libs-dev mailing list