RFR: 8307194: Enhance static-libs-image [v2]
Jiangli Zhou
jiangli at openjdk.org
Wed May 3 20:25:17 UTC 2023
On Wed, 3 May 2023 18:31:56 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update based on @erikj79 review comments and suggestions:
>> - Change to copy libjvm.a for $(JVM_VARIANT_MAIN) only in make/StaticLibsImage.gmk.
>> - Use $(OBJ_SUFFIX) instead of .o in make/modules/java.base/lib/CoreLibraries.gmk.
>
> make/Main.gmk line 261:
>
>> 259: endef
>> 260:
>> 261: $(foreach v, $(JVM_VARIANTS), $(eval $(call DeclareHotspotStaticLibsRecipe,$v)))
>
> If we are only using the libjvm.a from the main variant, we don't need to generate top level rules for all variants, or we could at least limit the dependency declaration at line 1109 to only need the main variant.
Changed to define/use the `libjvm.a` rule for the main variant only as suggested, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13768#discussion_r1184217800
More information about the core-libs-dev
mailing list