RFR: 8303669: SelectVersion indexes past the end of the argv array [v2]

[David Holmes]

On Thu, 4 May 2023 07:19:39 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> src/java.base/share/native/libjli/java.c line 1212:
>> 
>>> 1210:     *pret = 0;
>>> 1211: 
>>> 1212:     while (argc > 0 && *(arg = *argv) == '-') {
>> 
>> AFAICS this loop terminates at line 1388 and nowhere in the loop body does argc get modified. ??
>
> Reference to argc is passed down to GetOpt, where it is updated.

Ah I see - ouch!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13775#discussion_r1184794133