RFR: 8304937: BufferedFieldBuilder.Model missing writeTo(DirectClassBuilder)

Adam Sotona asotona at openjdk.org
Thu May 4 11:27:17 UTC 2023


On Sun, 26 Mar 2023 20:35:20 GMT, Chen Liang <liach at openjdk.org> wrote:

> Please review this simple patch to Classfile API that fixes a missing override that otherwise affects usage of chained class transforms. A test is included, that it fails on the missing method without this patch.
> 
> Please review a few other patches fixing bugs affecting normal usage of the Classfile API as well:
> #13167 #13021 #12996
> 
> I am trying to write a test for my in-progress patch to unify parameter mapping in core reflection in anticipation of #9862, however this bug prevents me from dropping method Signature and MethodParameters attributes with chained class transforms.

Marked as reviewed by asotona (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13187#pullrequestreview-1412885846


More information about the core-libs-dev mailing list