RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v2]
Roger Riggs
rriggs at openjdk.org
Thu May 4 20:37:31 UTC 2023
> Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem and Architecture instead of os.name and os.arch.
> They are direct replacements for the Platform enums except for UNKNOWN; its use is refactored to report errors via exceptions.
>
> Neither os.name nor os.arch should be assumed to be changeable;
> one test case is removed because it assumes os.name can be changed on the command line.
Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 28 commits:
- Remove unused static methods in DefaultImageBuilder
- Merge branch 'master' into 8304913-os-arch-jlink
- Merge branch 'master' into 8304913-os-arch-jlink
- Minor cleanup
- Merge branch 'master' into 8304913-os-arch-jlink
- 8304913: Use OperatingSystem, Architecture, and Version in jlink
- Simplify exception handling
- Simplify version parsing
- 8306678: Replace use of os.version with an internal Version record
- Use and test of "s390" verified by reviewer.
- ... and 18 more: https://git.openjdk.org/jdk/compare/0c6529d2...5bf9a506
-------------
Changes: https://git.openjdk.org/jdk/pull/13585/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13585&range=01
Stats: 156 lines in 7 files changed: 16 ins; 110 del; 30 mod
Patch: https://git.openjdk.org/jdk/pull/13585.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13585/head:pull/13585
PR: https://git.openjdk.org/jdk/pull/13585
More information about the core-libs-dev
mailing list