RFR: 8302845: Replace finalizer usage in JNDI DNS provider with Cleaner [v2]

Aleksei Efimov aefimov at openjdk.org
Fri May 5 19:08:29 UTC 2023


On Fri, 5 May 2023 18:13:29 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Aleksei Efimov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix comment
>
> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java line 163:
> 
>> 161:         }
>> 162:         // register a cleaning action to close the channel
>> 163:         // selector when this DNS client becomes phantom reachable
> 
> The change looks okay, it's just the comment here isn't quite right, it should say "to close the Selector when ...".

Thanks Alan. Fixed the comment in 757d242c66cdd5f12ce695a4c80ce5700eb66b4e.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13837#discussion_r1186417356


More information about the core-libs-dev mailing list