RFR: 8305486: Add split() variants that keep the delimiters to String and j.u.r.Pattern [v5]

Jaikiran Pai jpai at openjdk.org
Mon May 8 12:26:25 UTC 2023


On Mon, 8 May 2023 12:20:25 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Alternatively, one could remove the multiplication sign altogether...
>
>> I could replace it by the equivalent `&#xB7;`
> 
> I just locally used this as a replacement to `centerdot` and regenerated the javadocs. The generated javadoc HTML looks the same like the screenshot in my previous comment.
> 
> My only concern here is that this notation isn't used previously in any of our APIs and since it's part of a "regular" (non mathemical) sentence, it might be hard to understand what it is. I think it is relatable when it's part of some larger mathematical formula/explanation.
> 
> I just did a quick search of `centerdot` in the JDK source to see if it's been used in any API documentation currently and didn't find any such cases. So I still think using `*` would be clearer.
> 
> Having said that, if there are no objections from Roger or any other reviewers, it's OK with me too.

> Alternatively, one could remove the multiplication sign altogether...

Do you mean rewording it to something like:

> the array's length will be no greater than 2 times <i>limit</i> - 1

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13305#discussion_r1187383612


More information about the core-libs-dev mailing list