RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v65]

[Jim Laskey]

On Sat, 6 May 2023 02:53:49 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   CSR recommendations
>
> src/java.base/share/classes/java/lang/StringTemplate.java line 427:
> 
>> 425:      * {@link StringTemplate}. To accommodate concatenation, values are converted to strings
>> 426:      * as if invoking {@link String#valueOf(Object)}.
>> 427:      * @implNote {@link StringTemplate#STR} is statically imported implicitly into every
> 
> IMO the remark regarding  STR being auto-imported works better as an apiNote rather than an implNote.
> 
> Regarding interning, I think an implSpec of "may or may not be interned" provides maximum flexibility to the implementation.

Changed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1187409617