RFR: 8307466: java.time.Instant calculation bug in until and between methods [v2]

Naoto Sato naoto at openjdk.org
Mon May 8 16:02:32 UTC 2023


On Sun, 7 May 2023 17:58:26 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases did not correctly borrow or carry from the nanos to the seconds when computing using ChronoUnit.MILLIS or ChronoUnit.MICROS.
>> The errant computation was introduced by [JDK-8273369](https://bugs.openjdk.org/browse/JDK-8273369).
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Slight perf improvement using int instead of long for local nanosDiff

Looks good. Thanks for fixing the regression.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13846#pullrequestreview-1417076490


More information about the core-libs-dev mailing list