RFR: 8307466: java.time.Instant calculation bug in until and between methods [v2]

Roger Riggs rriggs at openjdk.org
Mon May 8 20:10:17 UTC 2023


On Mon, 8 May 2023 19:05:43 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Slight perf improvement using int instead of long for local nanosDiff
>
> I think that the explanation of the old code failing to properly consider carries and borrows, in the "Problem" section, is quite clear.
> 
> For the record, I added a more math-oriented comment.

@rgiulietti Thank you for the detailed math-oriented explanation.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13846#issuecomment-1538977506


More information about the core-libs-dev mailing list