RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v4]
Roger Riggs
rriggs at openjdk.org
Tue May 9 14:09:54 UTC 2023
On Tue, 9 May 2023 11:16:32 GMT, Glavo <duke at openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Correct Platform.is64Bit() to report address size of the architecture enum, not the running system
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 65:
>
>> 63: */
>> 64: public boolean is64Bit() {
>> 65: return arch != Architecture.X86;
>
> This change causes incorrect results to be returned on Linux ARM32.
My mistake; see above, `Platform.is64Bit()` is not needed by CDSPlugin.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13585#discussion_r1188657630
More information about the core-libs-dev
mailing list