RFR: 8306842: Classfile API performance improvements [v3]

Claes Redestad redestad at openjdk.org
Tue May 9 16:11:25 UTC 2023


On Tue, 9 May 2023 15:50:30 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed StackMapGenerator
>
> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 42:
> 
>> 40: @BenchmarkMode(Mode.Throughput)
>> 41: @State(Scope.Benchmark)
>> 42: @Fork(value = 1, jvmArgsAppend = {"--enable-preview"})
> 
> Suggestion:
> 
> @Fork(value = 1, jvmArgsAppend = {"--enable-preview",
>                                   "--add-opens", "java.base/jdk.internal.classfile=ALL-UNNAMED",
>                                   "--add-opens", "java.base/jdk.internal.classfile.constantpool=ALL-UNNAMED",
>                                   "--add-opens", "java.base/jdk.internal.classfile.instruction=ALL-UNNAMED"})

To make this runnable without manually adding a bunch of `--add-opens` flags

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13671#discussion_r1188819270


More information about the core-libs-dev mailing list