RFR: 8306842: Classfile API performance improvements [v4]
Adam Sotona
asotona at openjdk.org
Wed May 10 10:00:48 UTC 2023
On Tue, 9 May 2023 16:15:27 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> They are added in the `make/RunTests.gmk`: https://github.com/openjdk/jdk/pull/13550/files#diff-041bf69ea79b333b9ce99c1f879e398d698538530a35c361500b72631f059233R599-R608
>
> That seems misplaced. Please file an RFE to have this cleaned up.
>
> Each microbenchmark that has to add opens needs to take responsibility for that themselves and not change the environment for everything else. And all micros the benchmarks.jar should be runnable standalone, not rely on quirks in the make runner.
All benchmarks fixed and --add-exports removed from make file.
Thank you for pointing this out.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13671#discussion_r1189664602
More information about the core-libs-dev
mailing list