RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v2]

Justin Lu jlu at openjdk.org
Thu May 11 21:53:17 UTC 2023


> Please review changes to `EquivMapsGenerator.java` (which is used to generate the Locale equivalencies for the JDK).
> 
> The file previously used large concatenated Strings, which are now replaced with text blocks, in addition to some cleanup. No functionality is changed, the Locale equivalencies builds the same.

Justin Lu has updated the pull request incrementally with three additional commits since the last revision:

 - Adjust new lines to appease jcheck?
 - Review: remove new line literals for new lines
 - Review: fix method / var names

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13935/files
  - new: https://git.openjdk.org/jdk/pull/13935/files/7a43ab93..9574a984

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13935&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13935&range=00-01

  Stats: 16 lines in 1 file changed: 6 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/13935.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13935/head:pull/13935

PR: https://git.openjdk.org/jdk/pull/13935


More information about the core-libs-dev mailing list