RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v3]
Justin Lu
jlu at openjdk.org
Fri May 12 17:25:49 UTC 2023
On Fri, 12 May 2023 16:41:18 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove more ws in text block
>
> make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java line 344:
>
>> 342: }
>> 343:
>> 344: private static final String footerText = " }\n\n}";
>
> I'd prefer this one also be uppercased (and moved to a more suitable location).
ah, missed that one, probably because of it's location too. Made uppercased and moved closer to the rest of the static text variables.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13935#discussion_r1192626527
More information about the core-libs-dev
mailing list