RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v13]

[Jim Laskey]

On Mon, 15 May 2023 06:31:40 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update VirtualParser.java
>
> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 35:
> 
>> 33: public class MainMethodFinder {
>> 34:     private static boolean isPrivate(Method method) {
>> 35:         return method != null && Modifier.isPrivate(method.getModifiers());
> 
> Are you sure you want to allow null here? It seems like it's a bug in the caller if that happens.

Remnant of previous usage. Changed.

> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 38:
> 
>> 36:     }
>> 37: 
>> 38:     private static boolean isPublic(Method method) {
> 
> Is this left over from a previous iteration, it doesn't seem to be used.

Changed

> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 53:
> 
>> 51: 
>> 52:     /**
>> 53:      * Gather all the "main" methods in the class heirarchy.
> 
> heirarchy -> hierarchy

Changed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13689#discussion_r1194107274
PR Review Comment: https://git.openjdk.org/jdk/pull/13689#discussion_r1194105447
PR Review Comment: https://git.openjdk.org/jdk/pull/13689#discussion_r1194108052