RFR: 8306842: Classfile API performance improvements [v5]

Adam Sotona asotona at openjdk.org
Tue May 16 08:17:05 UTC 2023


On Mon, 15 May 2023 19:06:16 GMT, Glavo <duke at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - changed LinkedList to ArrayList in RebuildMethodBodies benchmark
>>  - added RepeatedModelTraversal JMH benchmark
>
> test/micro/org/openjdk/bench/jdk/classfile/RepeatedModelTraversal.java line 54:
> 
>> 52:     @Setup(Level.Trial)
>> 53:     public void setup() throws IOException {
>> 54:         models = new LinkedList<>();
> 
> I think `ArrayList` can be used instead of `LinkedList` here too. 
> 
> While this may not be an actual improvement, I don't think `LinkedList` should be used unless necessary.

I've replaced all `LinkedList` with `ArrayList` in the benchmarks, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13671#discussion_r1194784609


More information about the core-libs-dev mailing list