RFR: 8307990: jspawnhelper must close its writing side of a pipe before reading from it

[David Holmes]

On Tue, 16 May 2023 07:56:35 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> > I wonder if @Martin-Buchholz is able to look at this one?
> > My concern with changes like this is that they fix an issue but then have unexpected side-effects themselves.
> 
> Are there any specific concerns you have?

There seems to be more going on here than just closing the write side of the pipe. We will now error out if any of the readFully's do a short read, rather than just when reporting an error - which on the surface seems like a good thing, but what if harmless short-reads can actually happen in some contexts?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13956#issuecomment-1549538540