RFR: 8287834: Add SymbolLookup::or method [v2]

Paul Sandoz psandoz at openjdk.org
Tue May 16 18:28:45 UTC 2023


On Tue, 16 May 2023 17:06:02 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch adds a simpler method for composing symbol lookups. It is common for clients to chain multiple symbol lookups together, e.g. to find a symbol in multiple libraries.
>> 
>> A new instance method, namely `SymbolLookup::or` is added, which first searches a symbol in the first lookup, and, if that fails, proceeds to search the symbol in the provided lookup.
>> 
>> We have considered alternatives to express this, such as a static factory `SymbolLookup::ofComposite` but settled on this because of the similarity with `Optional::or`.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/java.base/share/classes/java/lang/foreign/SymbolLookup.java
>   
>   Co-authored-by: Paul Sandoz <paul.d.sandoz at googlemail.com>

Marked as reviewed by psandoz (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13954#pullrequestreview-1429165729


More information about the core-libs-dev mailing list