RFR: 8305785: Avoid redundant HashMap.containsKey call in java.util.regex

Jaikiran Pai jpai at openjdk.org
Wed May 17 12:53:50 UTC 2023


On Mon, 3 Apr 2023 16:58:15 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> `Pattern.namedGroups` and `Matcher.namedGroups` contains only non-null values. It means instead of separate `containsKey`+`get` calls, we can use single `HashMap.get` call and then compare result with null.
> Result code is a bit simpler and faster.

This looks OK to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13303#pullrequestreview-1430610391


More information about the core-libs-dev mailing list