RFR: 8307990: jspawnhelper must close its writing side of a pipe before reading from it [v2]

Volker Simonis simonis at openjdk.org
Wed May 17 16:00:25 UTC 2023


On Wed, 17 May 2023 14:55:00 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added test case
>
> src/java.base/unix/native/libjava/childproc.c line 408:
> 
>> 406:  * or the newly created jspawnhelper child process during the execution of
>> 407:  * Java_java_lang_ProcessImpl_forkAndExec().
>> 408:  * See: test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java
> 
> Is there a file missing from the commit? Where is JspawnhelperProtocol.java?
> It might be useful to include the bug number; though generally they can get stale and uninteresting quickly.

Sorry, I could say I wanted to see if somebody is really looking at this, but in reality I just missed to add the new test file to the commit :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13956#discussion_r1196738178


More information about the core-libs-dev mailing list