RFR: 8308270: ARM32 build broken after JDK-8304913

Thomas Stuefe stuefe at openjdk.org
Wed May 17 19:39:49 UTC 2023


On Wed, 17 May 2023 08:45:23 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:

> Build issue happens after https://git.openjdk.org/jdk/pull/13585:
> 
> $ make bundles
> ...
> jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum constant jdk.internal.util.Architecture.ARM
> 	at jdk.jlink/jdk.tools.jlink.builder.DefaultImageBuilder.storeFiles(DefaultImageBuilder.java:181)
> 	at jdk.jlink/jdk.tools.jlink.internal.ImagePluginStack.storeFiles(ImagePluginStack.java:486)
> 	at jdk.jlink/jdk.tools.jlink.internal.ImageFileCreator.writeImage(ImageFileCreator.java:168)
> 	at jdk.jlink/jdk.tools.jlink.internal.ImageFileCreator.create(ImageFileCreator.java:100)
> 	at jdk.jlink/jdk.tools.jlink.internal.JlinkTask$ImageHelper.retrieve(JlinkTask.java:860)
> 	at jdk.jlink/jdk.tools.jlink.internal.ImagePluginStack.operate(ImagePluginStack.java:194)
> 	at jdk.jlink/jdk.tools.jlink.internal.JlinkTask.createImage(JlinkTask.java:423)
> 	at jdk.jlink/jdk.tools.jlink.internal.JlinkTask.run(JlinkTask.java:286)
> 	at jdk.jlink/jdk.tools.jlink.internal.Main.run(Main.java:56)
> 	at jdk.jlink/jdk.tools.jlink.internal.Main.main(Main.java:34)
> 
> 
> With this PR I follow the https://github.com/openjdk/jdk/pull/13357 change to add a missing ARM32 architecture to the list of supported architectures: `X64, X86, AARCH64, RISCV64, S390, PPC64`.

Looks good. Thanks for fixing this.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14028#pullrequestreview-1431433623


More information about the core-libs-dev mailing list