RFR: 8308410: broken compilation of test\jdk\tools\launcher\exeJliLaunchTest.c
Adam Sotona
asotona at openjdk.org
Fri May 19 13:06:50 UTC 2023
On Fri, 19 May 2023 13:01:37 GMT, Adam Sotona <asotona at openjdk.org> wrote:
>> test/jdk/tools/launcher/exeJliLaunchTest.c line 39:
>>
>>> 37: {
>>> 38: //avoid null-terminated array of arguments to test JDK-8303669
>>> 39: char **argv = malloc(sizeof(char *) * argc);
>>
>> If this is building on all platforms then okay but I would have expected you'd need a cast here.
>
> I've learned that there are completely opposite rules for C and C++.
Tier1 tests just passed on all platforms.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14060#discussion_r1198935073
More information about the core-libs-dev
mailing list