RFR: 8308108: Support Unicode extension for collation settings [v3]
Alan Bateman
alanb at openjdk.org
Fri May 19 17:14:51 UTC 2023
On Fri, 19 May 2023 16:44:04 GMT, Naoto Sato <naoto at openjdk.org> wrote:
> I don't think there is any chance that the factory method returns a Collator that fails to meet the settings in the locale, because setStrength()/setDecompositon() with valid values never fail. So the returned instance will always have the requested strength/decomposition. Does this answer your question?
It's the last sentence that bothers me. I understand the setters can't fail but the last sentence of the proposed text makes it sound like invalid settings will be just ignored. So I think this sentence needs to be re-examined as I don't think I understand what it is trying to say now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14040#discussion_r1199193045
More information about the core-libs-dev
mailing list