RFR: 8308235: ThreadContainer registry accumulates weak refs [v2]

Alan Bateman alanb at openjdk.org
Mon May 22 06:21:00 UTC 2023


On Fri, 19 May 2023 08:26:31 GMT, Viktor Klang <duke at openjdk.org> wrote:

>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Change test to use nanoTime
>>  - Merge
>>  - Fix @run tag
>>  - Initial commit
>
> test/jdk/java/util/concurrent/Executors/UnreferencedExecutor.java line 38:
> 
>> 36:         int ncores = Runtime.getRuntime().availableProcessors();
>> 37:         long start = System.currentTimeMillis();
>> 38:         while (System.currentTimeMillis() - start < 5000) {
> 
> @AlanBateman Might want to have this based on `nanoTime()` such that changes to wall-clock doesn't impact the length of the run of the test.

Okay, that would be better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14047#discussion_r1199999336


More information about the core-libs-dev mailing list