RFR: 8306431: File.listRoots method description should be re-examined [v6]

Nagata-Haruhito duke at openjdk.org
Mon May 22 07:02:55 UTC 2023


On Fri, 19 May 2023 09:32:03 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Nagata-Haruhito has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Merge branch 'File_javadoc' of https://github.com/Nagata-Haruhito/jdk into File_javadoc
>>  - Drop exist to available
>>  - Merge branch 'master' into File_javadoc
>
> src/java.base/share/classes/java/io/File.java line 1828:
> 
>> 1826:      * namely {@code "/"}.  The set of filesystem roots is affected
>> 1827:      * by various system-level operations such as the disconnecting or
>> 1828:      * unmounting of physical or virtual disk drives.
> 
> I think you'll have to move this to the end of the method description, otherwise the paragraphs that follow will show up as "Implementation Note" too.

I think following two paragraphs belongs to `Implementation Note` too, because of UNC pathname and SecurityException. 
Is it wrong?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13526#discussion_r1200048699


More information about the core-libs-dev mailing list