RFR: 8307990: jspawnhelper must close its writing side of a pipe before reading from it [v3]

Volker Simonis simonis at openjdk.org
Mon May 22 07:37:01 UTC 2023


On Wed, 17 May 2023 17:01:53 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   REALLY adding the test :)
>
> test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java line 63:
> 
>> 61:         if (p.exitValue() == 0) {
>> 62:             String pwd = p.inputReader().readLine();
>> 63:             if (!Path.of("").toAbsolutePath().toString().equals(pwd)) {
> 
> It would be useful to print the unexpected string; it might help isolate what went wrong.
> And make it easier to understand what ERROR+2 means.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13956#discussion_r1200082310


More information about the core-libs-dev mailing list