RFR: 8308046: Move Solaris related charsets from java.base to jdk.charsets module [v3]
Naoto Sato
naoto at openjdk.org
Mon May 22 17:12:51 UTC 2023
On Mon, 22 May 2023 10:22:20 GMT, Ichiroh Takiguchi <itakiguchi at openjdk.org> wrote:
>> According to "JDK 20 Internationalization Guide"
>> https://docs.oracle.com/en/java/javase/20/intl/supported-encodings.html
>> Following Solaris related charsets are in "contained in jdk.charsets module" list.
>>
>> - PCK (x-PCK)
>> - EUC_JP_Solaris (x-eucJP-Open)
>> - Big5_Solaris (x-Big5-Solaris)
>>
>> These are not supported by Linux platform, so they should not be in java.base module.
>>
>> Note:
>> GHA Linux x86 builds were failed.
>> I think it's not related by my modified code.
>> I opened [JDK-8308051](https://bugs.openjdk.org/browse/JDK-8308051) GHA: Linux x86 builds failure
>
> Ichiroh Takiguchi has updated the pull request incrementally with one additional commit since the last revision:
>
> 8308046: Move Solaris related charsets from java.base to jdk.charsets module
Looks good. I think you may want to change `stdcs-aix` as well.
As to the JBS issue, please change the title to match the PR title, and add `noreg-cleanup` label
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13973#pullrequestreview-1437077458
More information about the core-libs-dev
mailing list