RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

[Jiangli Zhou]

On Fri, 19 May 2023 22:45:16 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> make/common/NativeCompilation.gmk line 1208:
>> 
>>> 1206: 	  $$(call ExecuteWithLog, $$($1_OBJECT_DIR)/$$($1_SAFE_NAME)_partial_link, \
>>> 1207: 	     $$($1_LD) $(LDFLAGS_CXX_PARTIAL_LINKING) $(LD_OUT_OPTION)$$($1_TARGET_RELOCATABLE) \
>>> 1208:                  $$($1_LD_OBJ_ARG))
>> 
>> This command line is missing `$$($1_SYSROOT_LDFLAGS)` which is causing it to fail in our builds with:
>> 
>> ld: library not found for -lSystem
>
> This is the mac failure, sorry if that wasn't clear.

Thanks @erikj79. Could you please help provide some more info on the build failure:

Which macOs version ran into the build issue? My mac is on Ventura 13.3.1 (a). It builds successfully for the `static-libs-image` target.

Does it fail when partially linking `libjvm_relocatable.o` only, or it fails when partially linking other native libraries as well on macosx? Could you please share the partial linking command, e.g. hotspot/variant-server/libjvm/gtest/objs/static/BUILD_GTEST_LIBJVM_partial_link.cmdline?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14064#discussion_r1200929473