RFR: 8308090: Add container tests for on-the-fly resource quota updates [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Tue May 23 09:04:11 UTC 2023
> Please review these test changes which implement automatic testing of container resource updates without JVM restart. Note that this merely tests container detection code handling this case. It doesn't do anything special for the JVM itself, though it might make sense to add some sanity checks should we detect certain limits changing. In another PR, though.
>
> As to the test design, it works similar to the shared temp tests: Interact between the two containers by virtue of a shared filesystem `/tmp` and creating marker files there in order to make them cooperate. Note that the new test needs `podman` version `4.3.0` and better (`4.5` is current).
>
> Testing:
> - [ ] GHA (still running)
> - [x] Linux x86_64 container tests on cg v1 and cg v2 system
> - [x] Newly added tests on Linux x86_64 cg v1 and cg v2 (`podman` and `docker`)
Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Merge branch 'master' into jdk-8308090-tests-container-on-fly-updates
- Fix whitespace
- 8308090: Add container tests for on-the-fly resource quota updates
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14090/files
- new: https://git.openjdk.org/jdk/pull/14090/files/761f410e..8cca3671
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14090&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14090&range=00-01
Stats: 18326 lines in 687 files changed: 9112 ins; 4973 del; 4241 mod
Patch: https://git.openjdk.org/jdk/pull/14090.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14090/head:pull/14090
PR: https://git.openjdk.org/jdk/pull/14090
More information about the core-libs-dev
mailing list