RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v3]

Wed May 24 11:05:04 UTC 2023

On Wed, 24 May 2023 08:20:32 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update Scenario.java
>>  - Update compilerOracle.cpp
>
> src/hotspot/share/compiler/compilerOracle.cpp line 1062:
> 
>> 1060:       char* newName = NEW_RESOURCE_ARRAY( char, i + 1);
>> 1061:       if (newName == nullptr)
>> 1062:         return true;
> 
> Should be `false`.
> 
> You could also add braces here.

right. I changed it

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13753#discussion_r1203898368