RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed May 24 12:14:55 UTC 2023
On Wed, 24 May 2023 09:16:46 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
> Please review this trivial adaptation for JDK-8308276.
Looks good - I apologize for having missed it.
test/jdk/java/foreign/TestHFA.java line 53:
> 51: final static SymbolLookup lookup = SymbolLookup.loaderLookup();
> 52:
> 53: static final OfFloat FLOAT = JAVA_FLOAT.withByteAlignment(4);
Is this even required - e.g. the alignment of Java float is 4 bytes...
-------------
Marked as reviewed by mcimadamore (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14116#pullrequestreview-1441682588
PR Review Comment: https://git.openjdk.org/jdk/pull/14116#discussion_r1204006404
More information about the core-libs-dev
mailing list