RFR: 8308452: Extend internal Architecture enum with byte order and address size

Martin Doerr mdoerr at openjdk.org
Wed May 24 22:33:54 UTC 2023


On Fri, 19 May 2023 19:19:40 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> The internal enum jdk.internal.util.Architecture does not provide information about the big or little endianness or the address size (64 or 32 bits).  The endian-ness and address size are intrinsic to the architecture.
> 
> The values of the enum are extended to separately identify the big endian and little-endian uses of the ISA.
> For example, `PPC64` and `PPC64LE` for the big and little-endian versions.  
> The enum values directly reflect the build-time artifacts and resulting executables.
> 
> This information about an architecture will make the enum more useful especially to identify a target platform in a cross-platform use case. A method is added to map well known aliases for the platforms to the Architecture enum.

I think the mapping from ppc64le to ppc64 should get removed with the introduction of ppc64le as separate architecture:
https://github.com/openjdk/jdk/blob/64f6681cc7bb184112adcf2b4f2c313e1b0a5c4f/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java#LL55C5-L55C5
Would you mind removing it with your change?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14063#issuecomment-1562010424


More information about the core-libs-dev mailing list