RFR: 8308804: Improve UUID.randomUUID performance with bulk/scalable PRNG access [v2]

Aleksey Shipilev shade at openjdk.org
Fri May 26 09:51:49 UTC 2023


On Thu, 25 May 2023 12:17:27 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Handle privileged properties
>>  - Use ByteArray to convert. Do version/variant preparations straight on locals. Move init out of optimistic lock section.
>
> src/java.base/share/classes/java/util/UUID.java line 127:
> 
>> 125:         static {
>> 126:             try {
>> 127:                 PRNG_NAME = System.getProperty(PROP_NAME_PRNG_NAME, null);
> 
> You'll have to use GetPropertyAction.privilegedGetProperty as this will otherwise fail if someone runs with a SM.

Good spot. Should be fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14135#discussion_r1206512318


More information about the core-libs-dev mailing list