RFR: 8308804: Improve UUID.randomUUID performance with bulk/scalable PRNG access [v4]
Roger Riggs
rriggs at openjdk.org
Fri May 26 15:33:08 UTC 2023
On Thu, 25 May 2023 14:04:35 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> src/java.base/share/classes/java/util/UUID.java line 149:
>>
>>> 147: } else {
>>> 148: try {
>>> 149: return SecureRandom.getInstance(PRNG_NAME);
>>
>> Part of the change here is that the RNG algorithm is configurable via a system property. The naming of the naming (java.util.UUID.prngName) hints that you might want it to be a standard system property but maybe it's for testing?
>
> Yes, I used them for testing, but left them in, because it would be convenient to have them around for field tuning and diagnostics. This would require a CSR, right?
I don't think there is a strong case for adding the system properties. They just add to the surface area that has to be maintained and add very little value except in very rare cases. If someone needs very special treatment they can build it outside of UUID and use the new UUID(long, long) constructor.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14135#discussion_r1206962862
More information about the core-libs-dev
mailing list