RFR: 8308960: Decouple internal Version and OperatingSystem classes

Mandy Chung mchung at openjdk.org
Fri May 26 16:08:54 UTC 2023


On Fri, 26 May 2023 14:57:21 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Decouple the jdk.internal.util OperatingSystem and Version classes to simplify class loading and avoid an indirect cyclic initialization.
> 
> Move the method to get the current OS version from OperatingSystem to the Version class and its initialization.
> Revert to using String.toUpperCase() instead of custom code to uppercase.
> 
> Update the uses of OperatingSystem.version to be Version.current.

Looks good.  Thanks for fixing this.  It will allow ClassFileDumper to use `Path`.

-------------

Marked as reviewed by mchung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14181#pullrequestreview-1446540821


More information about the core-libs-dev mailing list