RFR: JDK-8308913: Update core reflection for JEP 445 (preview)

David Holmes dholmes at openjdk.org
Fri May 26 21:05:08 UTC 2023


On Fri, 26 May 2023 02:06:55 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Explain in java.lang.Class how unnamed classes are modeled in core reflection.

src/java.base/share/classes/java/lang/Class.java line 192:

> 190:  * <h2><a id=unnamedClasses>Unnamed Classes</a></h2>
> 191:  *
> 192:  * The {@code class} file representing an unnnamed class is generated

Typo unnnamed (3 n's)

src/java.base/share/classes/java/lang/Class.java line 193:

> 191:  *
> 192:  * The {@code class} file representing an unnnamed class is generated
> 193:  * by a Java compiler from a source file from an unnamed class. The

"for an unnamed class." ?

src/java.base/share/classes/java/lang/Class.java line 196:

> 194:  * {@code Class} object representing an unnamed class is top-level,
> 195:  * {@linkplain #isSynthetic synthetic}, and {@code final}. While an
> 196:  * unnamed class does <em>not</em> have have a name in its Java source

typo: have have

src/java.base/share/classes/java/lang/Class.java line 201:

> 199:  * representing an unnamed class. Conventionally, a Java compiler
> 200:  * creates a class file where the class name matches the base name of
> 201:  * the class file; for example, a source file for an unnamed class

s/the class file;/the source file;/ ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1206160539
PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1206160610
PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1206160814
PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1206161235


More information about the core-libs-dev mailing list