RFR: 8308960: Decouple internal Version and OperatingSystem classes [v2]
Daniel Fuchs
dfuchs at openjdk.org
Mon May 29 09:59:53 UTC 2023
On Fri, 26 May 2023 16:54:42 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Decouple the jdk.internal.util OperatingSystem and Version classes to simplify class loading and avoid an indirect cyclic initialization.
>>
>> Move the method to get the current OS version from OperatingSystem to the Version class and its initialization.
>> Revert to using String.toUpperCase() instead of custom code to uppercase.
>>
>> Update the uses of OperatingSystem.version to be Version.current.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Rename jdk.internal.util.Version to OSVersion
Thanks for renaming the class. The renaming LGTM.
-------------
PR Review: https://git.openjdk.org/jdk/pull/14181#pullrequestreview-1449236628
More information about the core-libs-dev
mailing list