Integrated: 8308992: New test TestHFA fails with zero
Jorn Vernee
jvernee at openjdk.org
Tue May 30 15:32:07 UTC 2023
On Tue, 30 May 2023 12:17:00 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> The issue is that the fallback linker uses `copyFrom` when copying a by-value struct argument to an internal buffer, without first adjusting the size of the argument segment. This means that if the argument segment is 'too large' (i.e. larger than the layout it was linked with) we fail with an exception since the internal buffer is too small for the entire argument segment to be copied into.
>
> The fix is simply to use an exactly-sized copy instead, just like we do in other linker implementations. (The argument segment being too large is fine, all we care about is that it's large enough).
>
> Testing: jdk-tier5
This pull request has now been integrated.
Changeset: 804f198c
Author: Jorn Vernee <jvernee at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/804f198c73794ffce34a8a10c255656c25cf6d79
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
8308992: New test TestHFA fails with zero
Reviewed-by: mcimadamore
-------------
PR: https://git.openjdk.org/jdk/pull/14215
More information about the core-libs-dev
mailing list