RFR: 8308803: Improve java/util/UUID/UUIDTest.java [v3]

Roger Riggs rriggs at openjdk.org
Wed May 31 18:33:56 UTC 2023


On Wed, 31 May 2023 14:53:09 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> UUID is very important class that is used to track identities of objects in large scale systems. Yet, the coverage in JDK test is disappointing: it tests only 100 of UUID instances per test, which is way too small to detect collisions due to the bad randomness for example.
>> 
>> I have some pending work to improve UUID performance, and tests should be improved. 
>> 
>> The improved test still runs in less than 5 seconds on my laptop.
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Collect collisions and report them once at the end

Looks good, thanks for the updates.

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14134#pullrequestreview-1453903860


More information about the core-libs-dev mailing list