RFR: 8303530: Redefine JAXP Configuration File [v14]

[Lance Andersen]

On Wed, 31 May 2023 21:09:57 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Add a system property, jdk.xml.config.file, to return the path to a custom JAXP configuration file. The current configuration file, jaxp.properties, that the JDK supports will become the default configuration file.
>> 
>> CSR: https://bugs.openjdk.org/browse/JDK-8303531
>> 
>> Tests: XML SQE and JCK tests passed.
>
> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   additional javadoc update

Marked as reviewed by lancea (Reviewer).

src/java.xml/share/classes/module-info.java line 153:

> 151:  * <h4 id="Conf_CF_SP">User-defined Configuration File</h4>
> 152:  * In addition to the {@code jaxp.properties} file, the system property
> 153:  * {@systemProperty java.xml.config.file} can be set on the command line or at run-time

I think we can simplify to  "...the system property  {@systemProperty java.xml.config.file} can be set to specify..."

src/java.xml/share/classes/module-info.java line 182:

> 180:  * <ul>
> 181:  * <li><p>
> 182:  *      With the APIs for factories or processors

I do not think "With" makes sense here. perhaps just remove it completely

src/java.xml/share/classes/module-info.java line 224:

> 222:  * </li>
> 223:  * <li><p>
> 224:  *      If the property is not set on the factory, or with its system property,

perhaps. "or using a system property"

-------------

PR Review: https://git.openjdk.org/jdk/pull/12985#pullrequestreview-1454179699
PR Review Comment: https://git.openjdk.org/jdk/pull/12985#discussion_r1212327827
PR Review Comment: https://git.openjdk.org/jdk/pull/12985#discussion_r1212323773
PR Review Comment: https://git.openjdk.org/jdk/pull/12985#discussion_r1212324452