RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder()

[David Holmes]

On Wed, 1 Nov 2023 00:06:35 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Test thread factory is a mode similar to VM flags and should not be used in ProcessTools.createLimitedTestJavaProcessBuilder(). 

I'm not sure I agree with that. I think the test factory is a separate testing dimension, independent of JVM flags.

test/lib/jdk/test/lib/process/ProcessTools.java line 447:

> 445:      * Create ProcessBuilder using the java launcher from the jdk to be tested.
> 446:      *
> 447:      * @param isLimited Defines if jtreg options and test thread factory should be added

Suggestion:

@param isLimited If true, prevents the addition of jtreg options to the command, and ignores any available test thread factory

-------------

PR Review: https://git.openjdk.org/jdk/pull/16442#pullrequestreview-1707505556
PR Review Comment: https://git.openjdk.org/jdk/pull/16442#discussion_r1378344276