RFR: 8316969: Improve CDS module graph support for --module option [v6]
Calvin Cheung
ccheung at openjdk.org
Wed Nov 1 04:36:06 UTC 2023
On Fri, 27 Oct 2023 16:34:20 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Calvin Cheung has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
>>
>> - Merge master
>> - skip archiving full module graph is there is an incubator module
>> - fix typo
>> - simplify some code in modules.cpp
>> - comments from Alan and Ioi; add missing @run tag in the test
>> - Merge branch 'master' into improve-CDS-module-graph
>> - better way to check if a module is a JDK module
>> - initial review comments from Ioi
>> - 8316969: Improve CDS module graph support for --module option
>
> The new version looks really good now. I found one merge error and have a suggestion for adding one more test.
@iklam, @AlanBateman, I've pushed another small update. Please re-review. Thanks!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16016#issuecomment-1788393639
More information about the core-libs-dev
mailing list