RFR: 8316969: Improve CDS module graph support for --module option [v8]
Alan Bateman
alanb at openjdk.org
Wed Nov 1 11:31:06 UTC 2023
On Wed, 1 Nov 2023 04:34:35 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> Please review this changeset for adding support for `--module` (-m) option for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if the main module is specified. The module name will be stored in the ro region of the CDS archive. During runtime, the archived module name will be compared with the runtime module name. If comparison fails, the archived full module graph won't be used.
>>
>> Note: this RFE is a subtask of [JDK-8266329](https://bugs.openjdk.org/browse/JDK-8266329). More subtask(s) will be created to support other options such as `--add-modules`.
>>
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>
> more comments from Alan and Ioi; copyright year update
Marked as reviewed by alanb (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/16016#pullrequestreview-1708018487
More information about the core-libs-dev
mailing list