RFR: 8316969: Improve CDS module graph support for --module option [v3]

Alan Bateman alanb at openjdk.org
Wed Nov 1 11:31:06 UTC 2023


On Tue, 31 Oct 2023 20:45:11 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Do you prefer the `canArchive` setting be inside `if (CDS.isDumpingStaticArchive())` like the following?
> 
> ```
>     if (CDS.isDumpingStaticArchive())
>         canArchive = true;
> ```

That's fine. It has been harmless to have canArchive be true when not dumping but with the other changes in this PR then I think it's clearer to only set it when dumping. So I think your changes are good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16016#discussion_r1378678681


More information about the core-libs-dev mailing list